Chris Halcrow

Results 58 comments of Chris Halcrow

Hello, just working on docs, and now also think this is quite confusing. Just to make Zach's point more explicit, consider the following code: ``` recording, sorting = generate_ground_truth_recording( durations=[...

> Thanks @chrishalcrow > > Can you heck why tests are failing? Yes, it's to do with me originally changing the output from `namedtuple` to a `dict` (as documented). I'm...

> Tip: You have https://numpy.org/doc/stable/reference/generated/numpy.logspace.html to generate your samples. > > Benchamark comments: > > * I think you should fix your seed in your benchmark explictly. > * I...

> > Spike_length is just the number of spikes in the spike vector. So for generic data, this increases linearly with time. > > On a second thought, this seems...

> > Unfortunately, I can't review the synchrony metrics changes as I am not really well acquainted with the method. Maybe @DradeAW or @zm711 can take a look? > >...

Hello, realised that the `_add_spikes_to_spiketrain` function was basically just checking a bunch of array lengths then concatenating some arrays together, that were then used for testing. So it wasn't really...

> Hi. When we will have time I would be happy to discuss this function. The synchrony here if I understand correctly is the exact same timestamp but we could...

I _love_ this! The local workflow is great: by default you do what you always do, then only need to add the tag when you're working on that doc. Perfect!...

Hello, I just did the tutorial alongside some of my own data - it was fun! One thing that stuck out: it's not obvious to me _when_ you need to...

> I think an additional section 'when to apply motion correction' would be useful before the summary.... Thanks @JoeZiminski . Great. The main point I'd missed was: to see if...