Chris Halcrow

Results 58 comments of Chris Halcrow

Hmmm, I reckon I'd edit the base class to handle multi-segments. Maybe allow for `spike_train_data` and `y_axis_data` to be dicts of dicts? Then edit the data-wrangling in each subclass, and...

Hello, there's quite a lot of discussion about this topic here: #3483. I think my comment here might be helpful: https://github.com/SpikeInterface/spikeinterface/issues/3483#issuecomment-2859188115

Hello, sorry, I'm not an expert on this! But my understanding it that to mimic kilosort, you need to whiten before computing motion, like my code snippet you share. This...

Hi @FlyingFordAnglia thanks for posting the issue. Nothing obvious comes to mind. Could you post some more of your code leading up to the `plot_traces` function call, just so we...

Making the `run_info.json` file asap sounds reasonable to me. > As written here, I think it's this condition ` if set(self.params["metrics_to_compute"]) != set(self.params["metric_names"])` that's being used to check if the...

> Tested it and now all the extensions I need to compute are outputted as expected. I do still get the warnings, though, but I guess that was not changed?...

> I think the only real issue is that the values are now different. So from my perspective it would make the most sense to wait until your other PR...

Hello, I'm gonna close this - if we were to add this metric we should add as a separate metric. But before adding it, should show that it is a...

> I think this is an improvement. Another request we should think about is to have more flexibility in selecting what to plot in general. There are complaints about the...

Thanks @JoeZiminski - will take a look on Monday!