Chris Guida

Results 332 comments of Chris Guida

Waiting on @sip-21's PR here https://github.com/ca-ruz/plugins/pull/2#issuecomment-2405818832

@sip-21 After adding back concurrency, the tests are failing because they're trying to listen on port 9735... that actually doesn't seem necessary. Can you fix the tests not to require...

@cdecker do you have an example of any pytests that use the JSON schema from CLN to check the fields and types? That sounds amazing!

@ca-ruz some tests still failing, looks like blockstream is ratelimiting us

@ca-ruz just make an issue to refactor these tests to repeat ourselves less, and clean up the commits, then let's merge

Can you list which commands you want to do this to? I don't think it makes sense to do this "globally", whatever that means.

Ok. Renaming to reflect. Also you're talking about `embassy-cli` here, not `embassy-sdk`.

sigterm is only sent by embassyd though, not the base os

Aiden notes that docker figures this out somehow, we should figure out what that is and duplicate

@ca-ruz looks great so far! I think the testing around the emergency reserve could be improved.. there is an edge case where the user creates a channel and then their...