Chris Guida
Chris Guida
has conflicts
@sip-21 can you review? I know you had a formatter you were using as well
ACK https://github.com/lightningd/plugins/pull/568/commits/bd9bceeee7e0eed88b3e455e59efe89328404e21
@advorzhak @gudnuf I'd love to add this plugin, I am using it myself :) To get it over the finish line it will need tests that can be run in...
@advorzhak let us know if you need guidance to get this done! there isn't really anyone in charge of adding new plugins; it needs to be whomever is willing to...
Thanks for reporting!
Fixed by #574
Oh hmm, this is just a comment on what commits should look like... I definitely agree and have actually been requiring this on recent PRs. Shall we document this somewhere?
This is needed more than ever to fix the way we use the `TEST_NETWORK` global variable. See this PR: https://github.com/lightningd/plugins/pull/649#issue-2838675087 What we really need is a single abstract override fixture...
Btw @sip-21 noticed that this PR breaks mainnet on blockstream.info. Can you look into this @ca-ruz @iorch ?