Chris Smith
Chris Smith
@dmihal wondering if I could get a review on this? :)
> I believe it's not a bug It is a bug. This field is required as per [`ERC-4361`](https://eips.ethereum.org/EIPS/eip-4361), so if it was a docs issue then not providing it should...
I can still reproduce this on latest
Thanks for the review! I'm working on some fixes for the above as well as some other tweaks
@makarski This crate currently will read the service account file each time an access token needs to be generated. I'm wondering if this capability is intentional i.e. to support hot...
@makarski yes exactly, my goal is to provide a string/bytes/`ServiceAccountKey` value directly to this crate, rather than reading from a file. I do have a design question for you: if...
> Currently, if the file is swapped, one would need to implement logic on the caller side and create a new instance of a ServiceAccount. Unless I'm misunderstanding the code,...
Right now the file is lazily evaluated and will error when the first request is performed e.g. if the credentials file is invalid. This would probably be better anyway if...
Thanks! I'll include the change in my PR for this issue since it's highly related
I've been very happy recently. I can just do `provider: &impl Provider` in my methods without any `where` shenanigans