Chris Smith

Results 130 comments of Chris Smith

Renovate bot config needs to be updated to not update the ethers5 package

Fix for only upgrading ethers v6 here: https://github.com/WalletConnect/web3modal/pull/2741

I don't usually bump threads, but curious what is the holdup on this one? 😄 Seems like an easy win

We do not have ability to investigate this as we do not have anyone based in China. @liujiufa you share some console errors or network errors regarding which request(s) are...

@mhammond I can understand why the `Arc` itself isn't supported, but I would at least expect the `custom_type!()` to work? That keeps the `String` for actual FFI layer, while still...

@paxbun wrapping the Arc in a new type worked for me

I was thinking very similar! We keep `new()` that defaults to `ServiceAccount::from_file` but then have a second method `from_credentials()` which accepts a string This would also read the credentials file...

Is support for [hotswpping credential files on-disk](https://github.com/makarski/gauth-rs/issues/28#issuecomment-2062227084) an intentional feature? I'm thinking of removing this ability in my refactor as it would be simpler

Yeah let's wait for the gauth-rs PR to be merged before merging this. I'm working on a few more tweaks/fixes and I'd also like to test all this out in...

> Could you also have a look at https://github.com/rj76/fcm-rust/pull/10? The yup-oauth2 package is well maintained and also has what you need, if I'm correct. It doesn't look like that PR...