reqwest icon indicating copy to clipboard operation
reqwest copied to clipboard
verified publisher icon seanmonstar

feat(wasm): support request timeout

Open flisky opened this issue 2 years ago • 3 comments

Thanks for PR #1755, making wasm timeout support is super easy now.

fixes #1135 supersede #1274

flisky avatar Feb 24 '23 05:02 flisky

I've replace gloo-timers with wasm-bindgen functions.

(For the potential question: why not use web_sys::Window::set_timout_*? Because Window doesn't work in nodejs & webworker. However, I can switch into predefined functions if Window is only target.)

flisky avatar May 17 '23 03:05 flisky

is there a plan to merge this please?

aorticweb avatar Mar 04 '24 18:03 aorticweb

Hi any news about this one? To know if it's planned to add it or not?

Aursen avatar Jul 25 '24 10:07 Aursen

I don't usually bump threads, but curious what is the holdup on this one? 😄 Seems like an easy win

chris13524 avatar Jan 14 '25 18:01 chris13524

So sorry this slipped, yes this seems much simpler. Happy to add it!

It seems like there's a test failure in WASM, though. Related?

seanmonstar avatar Jan 14 '25 21:01 seanmonstar

~~Yes. I've shorten the timeout to reproduce timeout error in firefox.~~

It turns out that error message keywords didn't match, @seanmonstar

flisky avatar Jan 15 '25 02:01 flisky

@seanmonstar will there be a release with this any time soon? Thanks.

Nuhvi avatar Feb 06 '25 10:02 Nuhvi