Chris Smith

Results 30 comments of Chris Smith

I believe this could be resolved by changing this line https://github.com/open-telemetry/opentelemetry-dotnet/blob/55c5dd18e9bcb8f9f728aa1a0557bd5157c88362/src/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/TelemetryHttpModule.cs#L88-L91 to ```cs if (!context.IsPostNotification) { ActivityHelper.RestoreContextIfNeeded(context.ApplicationInstance.Context); } ```

Thanks @CodeBlanch I've setup a minimum reproduction here https://github.com/chris-smith-zocdoc/OtelSample You should be able to open the solution and hit F5 to run under IIS Express to see this easily. Set...

@CodeBlanch that may be true for `PreSendRequestHeaders` but not the other events which were showing smaller amounts of loss (~2% to 16%) ``` PreRequestHandlerExecute, PostRequestHandlerExecute, PostLogRequest ``` So I think...

Installing OpenMP through brew resolves this. `brew install libomp` A better error could be thrown with this suggestion

That looks promising, thanks @jdesrosiers

> Can this just be solved with one-hot encoding? How significant is the difference in model performance? No, doing this with one-hot encoding requires the tree to take many more...

@izeigerman did you have any more thoughts on how I should approach the implementation for this?

I can give it a shot, can you point me to the appropriate files that would need changed?

Agree that it would be nice if this library would use jsonschema to validate against the spec rather than requiring the user to do so

One area this would be super useful is having the end user write custom Lookup functions for capabilities that aren't bundled with the cdk. There are several open issues requesting...