Chris Smith

Results 30 comments of Chris Smith

@CodeBlanch I opened https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/761 to restore the context before all events

@jnm2 Do you feel there is sufficient test coverage for #3283 ? If so I (or someone else) could use those tests during the exploration phase of trying to fix...

Interestingly this is only affecting `CallContext.HostContext`, logical data and normal thread local / thread static are working ```cs [TestFixture] public class CallContextTests { private static readonly ThreadLocal tLocal = new...

Interesting, I'll look into that now

@CharliePoole Using the latest master 021cdac640ae3436c3be66a00166d5b2babe2dcc I still observe the serial loading behavior

I'm seeing this call stack when I run nunit3-console under dotTrace ![image](https://cloud.githubusercontent.com/assets/2537809/20356900/f85c96a0-abf3-11e6-94a9-55ec1102a037.png) Link to the code https://github.com/nunit/nunit-console/blob/8cb7226c0ad683fe5eb7a4eee8989aff08dc4ccb/src/NUnitEngine/nunit.engine/Runners/AggregatingTestRunner.cs#L92-L113 The command I'm using ``` nunit3-console ``` After the dlls are loaded, they...

@CharliePoole Any more thoughts on this issue? I have a proof of concept change on this branch https://github.com/nunit/nunit-console/compare/issue-132

> From a quick glance at your changes, they seem to mix the solution to the current problem with some changes that we may need in the future - when...

> Also, in case publish does a build+push combo, avoid requesting the normal BuiltPackage for that target, as that would be a wasted build. This does happen right now, how...

This kinda works now, you can specify the buildx output like this, which causes the image to get pushed to the registry ``` docker_image( build_platform = [ "linux/amd64", "linux/arm64", ],...