Chris Simpson

Results 33 comments of Chris Simpson

I really don't think this is an implementation of Kelson's method. You're fitting the BivariateSpline as a function of IMAGE pixel coordinates ```spline_fit = LSQBivariateSpline(x.ravel(), y.ravel(), ...)``` whereas Kelson says...

This is a complicated issue and I'm not sure there's a one-size-fits-all for every type of data so I think there should be a flexibility to choose a particular method....

The peak finding routine in scipy.signal works well for this, I've found, because the arc lines are all of similar width. In DRAGONS I've had to do some wrapping to...

Just a couple of quick notes here to bring things up to date regarding the extra stuff we hang on our `NDData`-like objects (`AstroData`) that functions use. 1) We have...

I don't think this is resolved. `axes_order` has some effect in certain circumstances but not in others, and I think that's unwanted behaviour. Below looks like an example similar to...

As a pretty fundamental axiom, I don't think the order of the outputs should be affected by the value of `with_units`. Since `with_units` will return a `SkyCoord` instance where appropriate,...

It was always my intention to submit a PR once we had something that works for us (the priority of course), which is now nearly the case (after much detailed...

My first guess is that there's a column which has only one good pixel in it. The error doesn't arise when fitting a spline. The fitting is done by `fit_1D()`...

I think this needs better logic when there aren't many sources in the reference catalogue. Or perhaps it just needs to create an image which is a few pixels larger...

distortionCorrect() doesn't change the rows of the pixels, it just shuffles them along each row. A glitch in the charge shuffling sounds reasonable but I don't think it's actually a...