Chris Simpson

Right, so the interactive tool makes it apparent that something is going wrong and the user can either reduce the "max shifted" parameter to prevent the trace from hopping the...

I've relabelled this as "under discussion" and "urgency-low" and removed "bug" because we understand it and nothing bad is happening. As per my last reply, I don't actually think there's...

I'm not sure what circumstances you're referring to. When stacking frames, the exposure time of the output is simply the exposure time of the first input frame (the entire header...

I've pushed a number of commits to `feature/makeSlitIllum_reviewing` -- I created a new branch because I changed the way the weights were calculated when collapsing the bins and thought this...

1. Will we have data without units after this is merged, given that units are added when the AD is created? The addition/subtraction operations we do are things like dark...

Yes, I think just like we assume that data in a FITS file are in ADU if there's no BUNIT, then we should assume they're in ADU when created from...

I'm not clear why the code at the end of `fluxCalibrate()` has had to change the way it has. What's wrong with the existing code that multiplies `ext` rather than...

But the previous version used `ext.multiply`, which calls `nddata.multiply` so is the failure to update units an omission from `NDData`? If the only operation that's missing from the previous code...

`NDAstroData` is hardcoded to use `VarianceUncertainty` (actually `ADVarianceUncertainty`), so if you want to set the `.nddata` directly then you either need to raise an error `if not isinstance(nddata.uncertainty, VarUncertainty)` or...

Can't you simply raise an exception in the `ADVarianceUncertainty.unit.setter`? Or maybe have `unit` return `_unit` if that's set and what I said above if not? It looks like `NDUncertainty` is...