Christian Stocker
Christian Stocker
Could you please seperate White Space only, test additions and code changes in single PRs or at least single commits? And please explain a little bit more, what exactly you...
ONe more question out of curiosity: "Update code to work with php5.3" sounds like it didn't work with PHP 5.3? Is that so? If yes, please tell me why, I'm...
@michaelklishin The code ran as well with PHP 5.3 (and 5.4) and I know travis-ci :) I'm just a little baffled usually to add namespaces just for the sake of...
The FFI class in this case is namespaced, so that shouldn't be an issue?
The problem in imagine is more that there is already 2.0.3 released, so I need to check for all cases. (Or just exclude 2.0.0 - 2.0.3 in composer.json, which shouldn't...
Just for the record. I updated https://github.com/rokka-io/imagine-vips with those additions (and excluded php-vips 2.0 in composer.json to make life easier in the code)
Agree with @jcupitt, if an attacker can run any PHP code, you're toast anyway. Of course you can potentially do even worse things with "compiling" C-code, but if your OS...
BTW, we're running now the 2.0.x version with FFI on production since a few days. Seems to work totally fine. Thanks a lot for your work.
Oh, come on. You know how this works. Send pull requests! ;)
which php version are you trying to install?