Connor Horman

> I disagree. I think if you put a atomic::fence(SeqCst) at the bottom of set_logger and use STATE.load(Relaxed) == INITIALIZED it not possible for a thread to read state ==...

I should probably mention this, now before I forget again. I took a look at the program, and there are some modifications necessary to HELP, in order to be usable...

If it's going to be a public macro, it should be called `boxed!()` instead. On Mon, 3 Oct 2022 at 10:46, Esteban Kuber ***@***.***> wrote: > The alternative that I...

+1 to this. As a resident of the #black-magic channel on the Rust Community Discord, having the ability to quickly check code that seems to probably be UB or not...

FTR, I've commonly used `Err(e)?` for `return Err(e)` - if this will cause issues in `if`/`else` blocks particularily, that would be a potential issue for my code.

I generally write ```rust if some_error_case{ Err(/*error value*/)? } ``` (or equivalent when using `match`), particularily when the error value (or the condition check) is more complicated - I find...

If we're guaranteeing the size of slice, perhaps: > The layout of a pointer to a slice of type `T` (`&[T]`, `&mut [T]`, `*const [T]`, or `Box`) is the same...

@rustbot label +T-lang +T-opsem +T-libs-api

I also do explicitly address an unsafe `T` returning `MaybeUninit::freeze` in the rationale and alternatives section and explain why I went for the safe version instead.

> Yes indeed. This is non-deterministic choice. And as the saying goes -- when considering the security of programs that do non-deterministic operations, you should assume the result to be...