Ryan Kim comments

Results 27 comments of


                                            Ryan Kim

trafficstars

feat: add json value converters

You need to move all the `Copyable` implementations of points in d5e33cfc7557117cc23a0b16eda1fa8c653321a9. Commit body should be corrected accordingly.

feat: add json value converters

1a02e54ee0c78e9c77e8ea7ea84825dfae229200 only works when it's a `DenseUnivariatePolynomial`. Please write codes as we do with `Copyable`.

feat: add json value converters

Please add unittests in 1a02e54ee0c78e9c77e8ea7ea84825dfae229200 .

feat: add json value converters

Some of changes in c8605d1485847ad9a3b4aa02f3936255da799de9 should be squashed.

feat: add json value converters

Please could you add unittests for `Fp3` and `Fp4` for c2c0d5778363bd1c32b57c213ee0a79b446b7012 ?

Need documents

@saliaku Actually, we are currently integrating Halo2 zkEVM circuits with Tachyon and our next step is to improve documentation before ETH denver. So this will be done by our team...

Change function signature `T Inverse()` to `std::optional<T> Inverse()`

@saliaku Oh thanks :) That would be awesome! If you have any questions on this, please feel free to ask us.

Change function signature `T Inverse()` to `std::optional<T> Inverse()`

The `Inverse()` is located in https://github.com/kroma-network/tachyon/blob/c6c7f83af0637973aec65fdef7a20d987060f0da/tachyon/math/base/groups.h#L79-L86 My idea is to change the content as follows. ```c++ // Inverse: a⁻¹ template < typename G2 = G, std::enable_if_t* = nullptr> [[nodiscard]] constexpr...

Change function signature `T Inverse()` to `std::optional<T> Inverse()`

The trade-off is other than this `XXXInPlace()` returns the reference of caller so that you can chain calling another method based on this reference. But `InverseInPlace()` can't do this.

Change function signature `T Inverse()` to `std::optional<T> Inverse()`

Close since https://github.com/kroma-network/tachyon/pull/424 is merged.