tachyon
tachyon copied to clipboard
feat: add json value converters
We want to receive intermediate data for verifying the process of generating a proof as a JSON file.
Therefore, in this PR, RapidJsonValueConverter
s for the following four classes was implemented.
- PrimeFieldBase
- Extension Fields
- Elliptic Curve Points (only short weierstrass)
- Geometric Points
- UnivariatePolynomial (sparse, dense and their coefficients)
- UnivariateEvaluations
You need to move all the Copyable
implementations of points in d5e33cfc7557117cc23a0b16eda1fa8c653321a9. Commit body should be corrected accordingly.
1a02e54ee0c78e9c77e8ea7ea84825dfae229200 only works when it's a DenseUnivariatePolynomial
. Please write codes as we do with Copyable
.
Please add unittests in 1a02e54ee0c78e9c77e8ea7ea84825dfae229200 .
Some of changes in c8605d1485847ad9a3b4aa02f3936255da799de9 should be squashed.
Please add unittests in 1a02e54 .
The unittest is implemented at univariate_dense_polynomial_unittest.cc
.
Please could you add unittests for Fp3
and Fp4
for c2c0d5778363bd1c32b57c213ee0a79b446b7012 ?
Please could you add unittests for
Fp3
andFp4
for c2c0d57 ?
Currently, There is no implementations of Fp3 and Fp4.
@dongchangYoo With f070c8b, I have 2 comments
- Is is a feat commit? I think it's a fix commit
- a -> an
@dongchangYoo With f070c8b, I have 2 comments
- Is is a feat commit? I think it's a fix commit
- a -> an
The implementation has been modified to copy the input string by adding an allocator
as an input. This change in handling strings, I believe, qualifies as a 'feat'.