tachyon icon indicating copy to clipboard operation
tachyon copied to clipboard

feat: add json value converters

Open dongchangYoo opened this issue 1 year ago • 8 comments

We want to receive intermediate data for verifying the process of generating a proof as a JSON file. Therefore, in this PR, RapidJsonValueConverters for the following four classes was implemented.

  • PrimeFieldBase
  • Extension Fields
  • Elliptic Curve Points (only short weierstrass)
  • Geometric Points
  • UnivariatePolynomial (sparse, dense and their coefficients)
  • UnivariateEvaluations

dongchangYoo avatar Jan 09 '24 10:01 dongchangYoo

You need to move all the Copyable implementations of points in d5e33cfc7557117cc23a0b16eda1fa8c653321a9. Commit body should be corrected accordingly.

chokobole avatar Jan 10 '24 00:01 chokobole

1a02e54ee0c78e9c77e8ea7ea84825dfae229200 only works when it's a DenseUnivariatePolynomial. Please write codes as we do with Copyable.

chokobole avatar Jan 10 '24 00:01 chokobole

Please add unittests in 1a02e54ee0c78e9c77e8ea7ea84825dfae229200 .

chokobole avatar Jan 10 '24 00:01 chokobole

Some of changes in c8605d1485847ad9a3b4aa02f3936255da799de9 should be squashed.

chokobole avatar Jan 10 '24 00:01 chokobole

Please add unittests in 1a02e54 .

The unittest is implemented at univariate_dense_polynomial_unittest.cc.

dongchangYoo avatar Jan 10 '24 01:01 dongchangYoo

Please could you add unittests for Fp3 and Fp4 for c2c0d5778363bd1c32b57c213ee0a79b446b7012 ?

chokobole avatar Jan 10 '24 11:01 chokobole

Please could you add unittests for Fp3 and Fp4 for c2c0d57 ?

Currently, There is no implementations of Fp3 and Fp4.

dongchangYoo avatar Jan 10 '24 14:01 dongchangYoo

@dongchangYoo With f070c8b, I have 2 comments

  1. Is is a feat commit? I think it's a fix commit
  2. a -> an

fakedev9999 avatar Jan 10 '24 23:01 fakedev9999

@dongchangYoo With f070c8b, I have 2 comments

  1. Is is a feat commit? I think it's a fix commit
  2. a -> an

The implementation has been modified to copy the input string by adding an allocator as an input. This change in handling strings, I believe, qualifies as a 'feat'.

dongchangYoo avatar Jan 11 '24 01:01 dongchangYoo