Chmouel Boudjnah

Results 278 comments of Chmouel Boudjnah

I think this should be called hosted gitlab instead of enterprise and I don't think we can assume gitlab.com

@savitaashture i don't think we do, generally the gitlab experience needs to be sane for hosted environement more than public, i believe that's how most of our users/customers would use...

I think it's needed for when we ship on openshift-console since they fetch the template as is maybe we should just strings.Replace them as we do here : https://github.com/openshift-pipelines/pipelines-as-code/blob/main/pkg/cmd/tknpac/generate/template.go#L88-L95 unless...

The "PAC Github app" never expires on cluster creation, def seems a github bug... where do you see this @sm43 ?

weird! let's keep this open and track it here when we sees it again....

I think we have fixed this, @sm43 would you know ?

may be fixed with the #606 work otherwise

this is now working with the watcher but we need to add the reason why it fails somewhere : for example on non existence `secret` : ```yaml scratch-my-back-pr-6rghw-task-referenced-internally: pipelineTaskName: task-referenced-internally...

LGTM let's wait CI is back before merging...

If the controller has started the PR, we may need to check the logs for patterns?