pipelines-as-code icon indicating copy to clipboard operation
pipelines-as-code copied to clipboard

Published 20 hours ago • verified publisher icon openshift-pipelines

Improve e2e tests

Open sm43 opened this issue 3 years ago • 5 comments

  • [ ] Test for failures: https://github.com/openshift-pipelines/pipelines-as-code/issues/572
  • [ ] Check that PAC has not fail. We currently go in a endless loop for 10mn waiting for a repo update but we don't check if PAC has fail or not.

sm43 avatar Apr 29 '22 06:04 sm43

Check that PAC has not fail

you means like failed to report the status?

sm43 avatar Apr 29 '22 06:04 sm43

If the controller has started the PR, we may need to check the logs for patterns?

chmouel avatar Apr 29 '22 07:04 chmouel

If the controller has started the PR, we may need to check the logs for patterns?

ah I see. may be we should add the event = sha in logs so that we can filter them as they are in json we might be able to do it 🤔

sm43 avatar Apr 29 '22 07:04 sm43

yes exactly! we had this other thread on slack about it : https://coreos.slack.com/archives/C0382KN768J/p1650877373441779?thread_ts=1650876346.239519&cid=C0382KN768J

chmouel avatar Apr 29 '22 07:04 chmouel

adding event = sha would be nice but if we configure for push and pull_request both then on an event logs would be mixed for a sha

may be event = sha & event-type = <> in the logs? wdyt? event-type = PullRequest/Push/Comment so that we can user can easliy filter using them

sm43 avatar May 02 '22 06:05 sm43