pipelines-as-code icon indicating copy to clipboard operation
pipelines-as-code copied to clipboard

Fixes devel replacement in release file configmap

Open sm43 opened this issue 1 year ago β€’ 2 comments

fixes #800

Signed-off-by: Shivam Mukhade [email protected]

Changes

Submitter Checklist

  • [ ] β™½ Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
  • [ ] πŸ“– If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
  • [ ] πŸ§ͺ 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • [ ] 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
  • [ ] πŸ”Ž If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

sm43 avatar Aug 26 '22 06:08 sm43

Codecov Report

Merging #805 (193fa34) into main (1deeb58) will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #805   +/-   ##
=======================================
  Coverage   65.86%   65.87%           
=======================================
  Files          75       75           
  Lines        4582     4583    +1     
=======================================
+ Hits         3018     3019    +1     
  Misses       1277     1277           
  Partials      287      287           
Impacted Files Coverage Ξ”
pkg/consoleui/tektondashboard.go 100.00% <0.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 26 '22 06:08 codecov-commenter

LGTM

let's wait CI is back before merging...

chmouel avatar Sep 01 '22 09:09 chmouel