Chris Morgan

Results 252 comments of Chris Morgan

Ping on review and feedback.

@ESP-Mars I'd be willing to be added as a maintainer to this repo. We do need another reviewer for this PR in any case. I have at least one other...

@tore-espressif updated PR coming in the next few days. Lots of cleanups and improvements, working on getting tests now although I ended up symlinking into the esp-idf/ install folder, couldn't...

@tore-espressif alright, pushed an updated branch with a ton of changes, plus unity tests, and a README.md. Next step after your next round of review is to move this out...

@tore-espressif very good review feedback, I appreciate it a ton. I should have an updated PR coming soon but also plan to split things into separate repos at this point,...

Hi @Charlesguo11, let me push some code tonight. I’ve been working on a rewrite of the audio player and it may be that the issue is solved due to the...

@Charlesguo11 https://github.com/chmorgan/esp-box/tree/audio_playlist_component is the work in progress branch. There is still an issue with mp3-demo related to playback switching on the ui side, something gets out of sync and the...

@igrr sure, I can do that. Are you reviewing other esp-box commits? I had another one open around an audio component that I'd also like to refactor out of esp-box...

@cpresser re 5.4, I agree, "must" matches international language for requirements. Sounds good to me.

@poeschlr thoughts? @chschlue mentioned this as a requirement for footprints but it isn't in the KLC today