esp-box icon indicating copy to clipboard operation
esp-box copied to clipboard

Lvgl update

Open chmorgan opened this issue 2 years ago • 3 comments

A number of fixes for things that look like they've been broken for a bit, plus update to v8.3 of lvgl to keep moving up as lvgl develops.

chmorgan avatar Aug 11 '22 14:08 chmorgan

@chmorgan If I may suggest something, it would be neat if we could use the IDF component manager for the LVGL dependency (https://components.espressif.com/component/lvgl/lvgl), instead of the submodule. For example, here's the way to add the LVGL dependency via the idf_component.yml file: https://github.com/espressif/esp-bsp/blob/74ece11b8870eabaf772576c026e27a0276da403/esp-box/idf_component.yml#L16-L18

The benefit compared to the submodule is that we can lock just the major version, and if the LVGL project releases a new minor version, the user can automatically benefit from it. With submodules, the LVGL version is fixed to the given commit.

igrr avatar Aug 11 '22 15:08 igrr

@igrr sure, I can do that.

Are you reviewing other esp-box commits? I had another one open around an audio component that I'd also like to refactor out of esp-box for reuse. It's not intended to compete with esp-adf, its a minimal implementation for smaller size and fully open code. Was hoping to discuss how/where that might go, if it should be scrapped and esp-adf used instead etc.

chmorgan avatar Aug 11 '22 15:08 chmorgan

Was hoping to discuss how/where that might go, if it should be scrapped and esp-adf used instead etc.

This sounds useful! I think we had a need for some kind of lightweight "audio playback" and "audio recording" functionality while working on examples in https://github.com/espressif/esp-bsp. @tore-espressif has looked into integrating ADF, but it was decided that it's too heavy for the purpose of simple examples.

So this contribution would be welcome, we just need to figure out where it would go and how it would be maintained. I'm not in the position to merge anything into the esp-box repository, but I will review https://github.com/espressif/esp-box/pull/30 and give some suggestions.

igrr avatar Aug 11 '22 15:08 igrr