Chris Morgan
Chris Morgan
Looks like a -vcs option was introduced but not mentioned in the README, submitted, https://github.com/rogpeppe/gohack/pull/47
@philipgreat I've forked at GitHub.com/chmorgan/go-serial2 and integrated fixes for mipsle. Still testing but if you have any other fixes I'd be interested in seeing them.
I've forked at GitHub.com/chmorgan/go-serial2 btw I'm seeing this issue on my test target. Should there be an option to be blocking vs. non-blocking? I'm not super familiar with the poller...
@nkovacs you'd recommend I pull in https://github.com/nkovacs/go-serial/commit/a72614425108022f3aef1c6285ac0af5016d4761 and https://github.com/nkovacs/go-serial/commit/73fc76fa08e4e3f6dc7f5090745016b849522ac2 then? In terms of usage should we update the example to make use of the poller? I'm not familiar with that...
@nkovacs and I think its ok to assume Go >1.9 at this point, at least I'm not excited about adding support for such old versions at the moment. Someone else...
Ahh very good! I’ll merge those changes this afternoon. I’m collecting all of the good fixes to the library so they are in one maintained repo. If you have any...
Thanks @nkovacs, changes merged into the go-serial2 fork, https://github.com/chmorgan/go-serial2
@smirkcat if you are interested I've forked this at GitHub.com/chmorgan/go-serial2. I'd be interested in this fix but would have to know more about why you are making the change, the...
On OpenWRT : error opening port:%!(EXTRA *os.SyscallError=SYS_IOCTL: inappropriate ioctl for device)
@philipgreat plan to push a PR for this fix?
On OpenWRT : error opening port:%!(EXTRA *os.SyscallError=SYS_IOCTL: inappropriate ioctl for device)
@philipgreat also your fork fails to build for me here on 1.11, reporting: ``` # github.com/philipgreat/go-serial/serial ../github.com/philipgreat/go-serial/serial/open_linux.go:62:2: const initializer nccs() is not a constant ```