Ingo Schommer

Results 110 comments of Ingo Schommer

Nice! What's the driver for showing subsequent clicks on the help button as an overlay, as opposed to simply showing the banner again? It adds UI variations and complexity. Although...

I also find the content layout a bit weird: The list of three links ("Editing files", "moving files", "deleting files") seems a bit out of context. It could be unclear...

> Providing quick links to the most popular articles people are searching for in User help. It alleviates the time need for people to go into user help and searching....

Looking in `LeftAndMain->init()`, there's non-trivial logic about requirements includes (e.g.`extra_requirements_css`). I wouldn't want devs to override an entire template just to add this - in particular since modules use this...

I was going to say that the whole `Requirements` system is becoming less relevant with the uptake of frontend asset bundlers (Webpack etc), but then again: HTTP/2 makes it feasible...

Ugh, can we not? `i18n::pluralise()` in PHP is a dirty hack, and only works in (some) English nouns. I propose we make all plurals available from translation files, and have...

Right, badly described ticket leading to misunderstandings. I don't want us to recreate the english-focused pseudo-automatic pluralisation that's been part of [DataObject](https://github.com/silverstripe/silverstripe-framework/blob/4.0/src/ORM/DataObject.php#L694) since 2.x days. I agree with Chris' sentiments.

Synk runs their own [PHP Vulnerability Database](https://snyk.io/docs/snyk-for-php) so we'd need to report issues in our own modules there, as well as encouraging the community to do so. The [Symfony Security](https://github.com/FriendsOfPHP/security-advisories)...

Github only covers NodeJS dependencies for us, it doesn't scan PHP. Ideally we have one solution which does both. Even if it did scan PHP, we've got repos outside of...

Of course I missed one: https://dependabot.com/ has been acquired by Github, and does this all for free. Including PHP! I can't see where it gets security advisories from in the...