Ingo Schommer

Results 111 comments of Ingo Schommer
trafficstars

Removed milestone because it was tagged with `change/major`, which we interpret as an API change that needs to happen prior to beta1. But reading through the ticket, I don't think...

I think this is going to be more helpful when regarded as built-in batch abilities on a GridField - I don't want to invest more time into complicating the tree...

@unclecheese This is a tricky one. One the one hand, queries like `readOnePage` are designed as a basis for a "Content API" provided by the CMS - and `readOneSiteTree` is...

@mikenz What was your rationale for skipping the `Page` class? It's a pretty lightweight class after all. This might also be a trigger to state that it is indeed a...

We've had a related discussion back in 2016 about [namespacing Page](https://github.com/silverstripe/silverstripe-framework/issues/5844). The accepted solution there was the same as Loz' example from above. @silverstripe/core-team I'm recommending that we document the...

> Make a CMS Field for the redirect type (301 or 302) I don't think giving CMS authors the choice between a permanent and temporary redirect is a good default...

301 Permanent redirects are exactly what RedirectorPages are: A permanent redirect from one page to another page, or another URL. Arguing that they're temporary redirects because pages could be theoretically...

> Change default response to be no-cache so the 301 is not cached. I think not caching makes these pages more computationally expensive than they need to be. Keep in...

> ok, that sounds like a reasonable solution. I'll be happy to implement this. What branch will we merge this into? I'd be fine with 3.x for this - it's...

> In that scenario you'd expect most visits to be unique anyway and this still leads to CMS users seeing 301s to the wrong place after editing a page URL......