Ingo Schommer

Results 111 comments of Ingo Schommer
trafficstars

The [push event docs](https://developer.github.com/webhooks/event-payloads/#push) state: > The array includes a maximum of 20 commits If devs on this repo have a habit of pushing up larger amounts of commits at...

Here's a video demonstrating the issue (in latest Chrome): https://monosnap.com/file/svhrdJZenzrZBRCyYkC121DW2FP0kW. @phalkunz Is that an easy fix? Probably just a CSS animation.

Template renders can get expensive depending on the project implementation. Adding two page renders to every dev/build is a bit of an overhead that I'd rather avoid (~1-3s?). As mentioned...

Discussion on mailinglist: https://groups.google.com/forum/#!topic/silverstripe-dev/VFXrusjAnKE

Since we provide an `Upload_Validator->setAllowedExtensions()` API, this should be possible without the YAML workaround you described - adding `type/bug` and `impact/high` since file extension restriction can be important depending on...

I've confirmed that `Verioned->publishSingle()` does NOT call ` $owner->invokeWithExtensions('onBeforePublish');` when no changes need to be published (in SS4). Both "safe draft" and "publish" buttons are clickable regardless of any changes,...

@Firesphere Can you add some more detail on the context of this issue here? Did you expect the extension to have an effect on publish, even though core didn't think...

@Firesphere Do you want to send a PR for `onAfterSkippedPublish`?

On a more general note, I'm keen to phase out these kind of advanced media insertion utilities in favour of content blocks - which will prove a much more robust...