Chia-Ping Tsai

Results 46 comments of Chia-Ping Tsai

@nizhikov thanks for this refactor. let us deal with next PR :)

> In order to move ConfigCommand to tools we must move all it's dependencies which includes KafkaConfig and other core classes to java. This PR moves log cleaner configuration to...

> ConfigCommand -> DynamicBrokerConfig -> LogCleaner ummm, I assume that will not be a issue if we get rid of zk after 4.0 :)

@nizhikov thanks for doing this hard job!

@ghostspiders Do you have jira account?

@nizhikov thanks for taking over this big issue. I'd like to give a review. However, it is a bit huge. Is it possible to split this PR into small PRs...

> There are two separate PR's that moves tests of command to tools: oh, sorry that I did not notice that you have tried to make small PRs. will take...

@nizhikov please rebase it. I feel we can complete this hard work this week :)

> Are you suggesting to find more reviewers for this PR? Yep, if they have free cycle 😃 Anyway, I will take a look later. Thanks for updating code

@nizhikov sorry for late review. could you rebase code and I will take a look later.