kafka
kafka copied to clipboard
KAFKA-14589 [3/3] Tests of ConsoleGroupCommand rewritten in java
This PR is part of https://github.com/apache/kafka/pull/14471 Is contains some of ConsoleGroupCommand tests rewritten in java. Intention of separate PR is to reduce changes and simplify review.
Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
Hello @showuon
Can you, please, take a look? I've checked CI results and it seems OK for me.
Hello @mimaison @jolshan Can you, please, take a look?
Hello @showuon @jolshan @mimaison
Can you, please, take a look?
Hello, @rreddy-22 @dajac
Can you, please, take a look at these changes?
It PR moves test of ConsoleGroupCommand from Authorizer test and Sasl test to tools.
It very small (+200, -100).
Big PR where all command code rewritten in java - https://github.com/apache/kafka/pull/14471
Right now, changes in ConsoleGroupCommand leads to conflicts in my PR which is hard to resolve.
Hello @chia7712
I checked CI results and failures seems unrelated to changes for me.
@nizhikov I feel this PR is ready, and so please check (or list) the failed tests. If they are unconnected to this PR, I will merge it.
the failed tests pass on my machine.
./gradlew cleanTest core:test --tests LogDirFailureTest --tests ReplicaManagerTest --tests TransactionsTest --tests SaslPlaintextConsumerTest tools:test --tests MetadataQuorumCommandTest
will merge it
@nizhikov thanks for this refactor. let us deal with next PR :)
@chia7712 Thank you for the review and merge.