kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-15610: Fix CoreUtils.swallow() test gaps

Open ghostspiders opened this issue 1 year ago • 3 comments

The CoreUtils.swallow() method in different logging levels test.

ghostspiders avatar Feb 21 '24 15:02 ghostspiders

Hi, @divijvaidya please review this

ghostspiders avatar Feb 21 '24 15:02 ghostspiders

There is a previous PR open for this at https://github.com/apache/kafka/pull/14583

I have a comment there on possible usage of spy. Can you please explore that approach and let us know why it might or might not be feasible.

divijvaidya avatar Feb 22 '24 10:02 divijvaidya

@divijvaidya I am using Mockito's verify to test CoreUtils.swallow(), but I am encountering an 'Argument(s) are different! Wanted:' error because the parameter is a function. I currently do not have a good solution for this issue.

ghostspiders avatar Feb 25 '24 17:02 ghostspiders

@ghostspiders Do you have jira account?

chia7712 avatar Apr 11 '24 10:04 chia7712