Tong Chen

Results 68 comments of Tong Chen

Thanks. Can I say that the two implementation in MLIR reflected the two optional types: None type and tensor?

@AlexandreEichenberger I modified the document based on your comments.

I will update the document with a new PR from an update-to-date version. It is difficult to merge a conflicted document file.

I will add some possible work items. - Handle control flow for onnx dialect. The current implementation targets at operations in serial. For example, the constProp does not handle the...

@sorenlassen Please resolve the conflict. I will try to merge this PR first once it passes the test.

> are you planning to do a version where only the missing tests are listed (avail - already here)? Not in this PR. Need to find a unified way to...

To keep the code simple, I prefer not to change the index for the 'then' and 'else' subgraph. To me, the index is anyway implementation dependent and the string name...

I agree that the output `onnx.If(%1) ({A}, {B})` is confusing to user. Previously I thought the index is only used in accessing the then/else region in code. It may require...

Options for onnx-mlir-opt should be considered too.

Our updating onnx was held off because an incoming release. I checked the changes in onnx and it seems that there are only a few changes affect us. There are...