onnx-mlir
onnx-mlir copied to clipboard
onnx
fixes for SeqType and sequence ops
As I implemented OptType in PR #1589 I noticed some issues with SeqType and sequence ops that are solved here:
- SeqType required its element type to be a ShapedType, which conflicts with its use with a map element type in ZipMap
- the SequenceConstruct op decomposition didn't support most data types
- we didn't infer shapes for the SequenceConstruct op
Note that Conversion/KrnlToLLVM/KrnlToLLVMHelper now depends on Dialect/ONNX/ONNXOpsHelper for mlirTypeToOnnxType. Please let me know if there's a better way to reuse this logic.
@chentong319 is the person on our end that did a lot of the sequences. I really would like him to review it, he is currently away for another 2 weeks, would that be ok with you?
@chentong319 is the person on our end that did a lot of the sequences. I really would like him to review it, he is currently away for another 2 weeks, would that be ok with you?
that's ok, I'm happy to wait
@sorenlassen Please resolve the conflict. I will try to merge this PR first once it passes the test.
@sorenlassen Please resolve the conflict. I will try to merge this PR first once it passes the test.
@chentong319: done
