Chris Hennes

Results 699 comments of Chris Hennes

It lists a license file named "LICENSE" in its metadata, but I don't see that file.

@adrianinsaval I see this is marked as Draft -- is it actually still a work-in-progress?

No rush, I'm just reviewing these older PRs to clean things up.

@PaddleStroke what are your thoughts on continuing this PR? It seems that it had some architectural issues that might warrant a complete restart. Do you want to keep this PR...

Thanks for your patience, and sorry this fell off my radar in the first place. As @donovaly suggests above, I'm going to leave this un-squashed in case one of the...

Just to port over my comment from #6167 -- this is a high priority item now, it is blocking our migration to Qt6.

It's not that they don't work in general, it's that they are broken in various places throughout our codebase, and Qt no longer provides diagnostics. See @wwmayer's post here: https://forum.freecadweb.org/viewtopic.php?p=650866#p650866

The rules for filenames are unrelated to the rules for identifiers (and vary based on the OS!) -- can we stop using the filename as an identifier? Replace it with...

No, this just fell off my radar. I don't think the code in this PR is quite right, it probably makes the most sense to just close it. We could...