Chris Hennes

Results 699 comments of Chris Hennes

@luzpaz can you invite someone from that community to take a look at this then? I don't see any particular issues.

Sorry for the delay on this, I just can't find a way to reproduce the error message (so I hesitate to say I've "reviewed" the PR!). Can you tell me...

Nevermind, got one. Thanks for the fix!

I have learned from my previous review experience: could you please re-submit without combining the two things? Make one PR for the ranged for loops, and one for the auto?...

Sure thing: in order... 1. First, the core developers do not all agree perfectly about `auto`: I prefer more of it, and Werner less, for example. Your example shows a...

> The timer in ShortcutManager is used for this purpose. In fact, the `Multi-key delay` specifies the time to wait for more keystorke, after which the pending action will be...

@realthunder if you are bored with working on the TNP mega-merge and want a break 😆, my impression of this PR is that it's ready for a final review once...

Since @wwmayer added this function (nine years ago) I'll leave it to him to decide whether there is still some potential use-case. Obviously otherwise I think the removal is fine.

Is the discussion on this one resolved? (That is, is it ready for review?)