FreeCAD [Start] Fix First Selected Theme Settings Being Applied

Fixes https://github.com/FreeCAD/FreeCAD/issues/16425 , if a new user does not click on any theme in the Start First Run widget then the default selected theme's entire settings are not applied, this PR fixes that issue.

Please backport to 1.0

Sep 11 '24 10:09 Syres916

I don't understand this placement of the calls to themeChanged -- why is it happening in the button setup method?

Sep 13 '24 02:09 chennes

I don't understand this placement of the calls to themeChanged -- why is it happening in the button setup method?

It was the only way I could easily get the end result, I'm certainly open to suggestions.

Sep 13 '24 11:09 Syres916

This isn't really a Start WB thing -- remember that Start is optional, and it's possible to run FreeCAD without it. If we need to actually execute a preference pack on first start, that is a more core Gui change, IMO.

Sep 13 '24 13:09 chennes

@Syres916 are you picking this up again?

Oct 05 '24 08:10 maxwxyz

@Syres916 ping

Oct 19 '24 05:10 maxwxyz

@Syres916 @hyarion is this PR obsolete with the merge of https://github.com/FreeCAD/FreeCAD/pull/17410

Nov 09 '24 16:11 maxwxyz

The fix for 1.0 was done in start. Chennes mentions that start is optional, if a user doesn't use it, then the autodetect and apply fix won't run.

Nov 09 '24 16:11 hyarion