Barry Chen comments

Results 17 comments of


                                            Barry Chen

"Whoa! Firefox Screenshots went haywire..." error is displayed if the "Copy", "Download" or "Save" button is clicked for a screenshot selection that exceeds 32800 pixels

@djh42 The issue with download cancellations will be fixed in the next Firefox release.

Investigate "Attempted makeEl before iframe was initialized"

(I'm not familiar with the code from when the issue was initially filed, but my comment probably still apply.) All three iframes are initialized in the same promise chain when...

Focus the iframes when moving through shot creation flow

Not sure I quite understand the description. Nothing is auto focused on the preselection frame, so I don't know what's lost or different when moving to the selection frame. The...

Fix Intermittent Selenium Test Failures

I'm re-opening this because we've been experiencing these failures quite frequently this week. Here is what I know about these failures: - "should take a shot" (the second one) and...

"This isn’t a standard Web page, so you can’t take a screenshot of it." notification is displayed on certain pages when the "Take a Screenshot" context menu option is used

Duplicate of https://github.com/mozilla-services/screenshots/issues/3778

Add Selenium Test for DPI Scaling

I don't have any experience with xpcshell tests, so I'll defer. @johngruen Is there a particular test you like from [this list](https://github.com/mozilla-services/screenshots/issues?q=is%3Aopen+is%3Aissue+label%3Atesting+selenium+author%3Achenba) if we don't do this one?

Addon errors showing up in server sentry

The DSN from the server has precedence in auth.js's `getSentryPublicDSN`. It's not obvious why though.