screenshots icon indicating copy to clipboard operation
screenshots copied to clipboard

Published 20 hours ago • verified publisher icon mozilla-services

Add Selenium Test for DPI Scaling

Open chenba opened this issue 7 years ago • 3 comments

This could be possible by changing the value of layout.css.devPixelsPerPx.

chenba avatar Mar 06 '18 14:03 chenba

Seems like a unit test might be more appropriate for testing this code path. Maybe when we move towards in-tree tests, we could write an xpcshell test for this.

jaredhirsch avatar Mar 07 '18 17:03 jaredhirsch

I don't have any experience with xpcshell tests, so I'll defer.

@johngruen Is there a particular test you like from this list if we don't do this one?

chenba avatar Mar 15 '18 18:03 chenba

@chenba Ah right, we wanted a certain number of tests this quarter. This is probably fine to attempt via Selenium, then. Also, since uploads are disabled in a number of important edge cases, might be worth having a test for those, though that's not in the list :+1:

jaredhirsch avatar Mar 15 '18 20:03 jaredhirsch