Barry Chen comments

Results 17 comments of


                                            Barry Chen

Add Selenium Test for Making a Selection with Mousemove

With selenium-webdriver 4.0.0-alpha.1 and geckodriver 1.10.0 or 1.11.0 (and a 61.0a1 Nightly), perform a mouse selection with `press().move().release()` does not work. The selection is started but then never finishes.

"Index or size negative or greater than allowed amount" error is displayed if the "Copy" or "Download" button is clicked for a zero-area selection

Sentry: https://sentry.prod.mozaws.net/operations/screenshots-addon-dev/issues/4287898/ Asa also reported this error message in the Screenshots Slack channel. But he was trying to take a shot of a tweet on Twitter, so I don't know...

Run `npm ci` insted of `npm install` in CircleCI

Kicking this into the backlog until we upgrade to nodejs 10.x.

Run `npm ci` insted of `npm install` in CircleCI

Depends on #4804

After dragging the scrollbar, a selection is automatically performed when hovering the page

Fix for this is in Jared's comment over at https://github.com/mozilla-services/screenshots/pull/4401#issuecomment-387524590

Investigate "Invalid tab ID"

The last comment's from almost four months ago. Is this still an issue?

Screenshots of IPv6 addresses don't work

Hey @Tacklebox, thanks for the comment. You're correct about `isURL()`. It looks like the error is from a regex--the one in `originFromUrl()`.

Notification message on error doesn't make sense

Does this still `needs:UX` or at least copy for the new message? @johngruen?

"Whoa! Firefox Screenshots went haywire..." error is displayed if the "Copy", "Download" or "Save" button is clicked for a screenshot selection that exceeds 32800 pixels

Did we ever reach a decision on what to do here? We could, in addition to a warning, prevent a selection with a side greater than 32767 pixels. @johngruen ?

"Whoa! Firefox Screenshots went haywire..." error is displayed if the "Copy", "Download" or "Save" button is clicked for a screenshot selection that exceeds 32800 pixels

There is an area limit of 472,907,776 pixels. That should be taken into account as well. And `devicePixelRatio` need to be factored into the calculations for HiDPI.