screenshots
screenshots copied to clipboard
mozilla-services
After dragging the scrollbar, a selection is automatically performed when hovering the page
[Affected versions]:
- Nightly 55.0a1 (Build ID:20170418030220)
[Affected Platforms]:
- All Windows
- All Mac
- All Linux
[Prerequisites]:
- Have latest Nightly build with Screenshots installed and a clean profile.
- The "extensions.screenshots.system-disabled" pref is set to false.
[Steps to reproduce]:
- Open the browser and profile from prerequisites and navigate to any website (eg: imdb.com).
- Click the Screenshots button from browser toolbar.
- Click the Firefox scrollbar and scroll the page.
- Release the mouse and hover the page content.
- Observe the brower behavior.
[Expected result]:
- The Screenshots overlay is not dismissed and no selection is performed.
[Actual result]:
- Automatically a selection is performed when hovering the page content.
[Notes]:
- The issue is also reproducible on stage server.
- Here is a screen recording with the issue:
My googling about how to detect this case shows lots of hacky solutions and no good ones.
Maybe the best solution is just to ignore clicks that are near or past the edge of the screen. Inboard scrollbars lead to clicks inside the page, on Windows the clicks will actually be outside the window.
Another option might be to specifically look for scroll events during mousedown/mouseup, and ignore the click in that case. That seems more complicated, and might mess up the scroll behavior when you get near the edge of the screen.
@ianb I wonder if this is a symptom of some bug with async scrolling? The latest comment in bug 1211610 indicates that APZ scrolling isn't yet ready to ride the trains. We might want to see if @SoftVision-CosminMuntean can repro on other channels before figuring out a workaround.
I remember this bug from a long time ago – it's the weird but apparently normal behavior that scrolling produces mousedown/mouseup events (maybe mousemove too?) And if you google it, you see a bunch of people discussing the issue from a long time ago.
We might want to see if @SoftVision-CosminMuntean can repro on other channels before figuring out a workaround.
This issue is reproducible on all channels (Firefox release, Beta, Aurora and Nightly). I have tried to test also older versions of Firefox, but the add-on is not working on versions < 51.0.
who even drags the scrollbar anymore besides QA folk? (my dad probably)
I have retested this issue and is still reproducible on Windows and Linux using the latest Screenshots custom build on stage, created from Github repository. But, it seems that the issue is no longer reproducible on Mac OS. Is there a chance that the fix is only applied on Mac OSs?
Yes, I thought the inboard scrollbars were only an issue on Macs, so the offset only applies to macs. Probably this should be set to all platforms (but I don't have a system to confirm)
Fix for this is in Jared's comment over at https://github.com/mozilla-services/screenshots/pull/4401#issuecomment-387524590
