Dariusz Jędrzejczyk
Dariusz Jędrzejczyk
Some `Disposable`s should be disposed with a chance to clean up the underlying resources. At the same time it is desired to coordinate logic that depends on successful disposal. Specifically,...
``` java.lang.AssertionError: Async errors occurred. See suppressed! at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:57) at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:42) at io.servicetalk.http.netty.HttpOffloadingTest.serverOnCloseIsOffloaded(HttpOffloadingTest.java:251) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725) at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60) at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131) at org.junit.jupiter.engine.extension.TimeoutInvocation.proceed(TimeoutInvocation.java:46)...
As noticed by @ idelpivnitskiy: in `RoundRobinLoadBalancerTest` the `serviceDiscoveryPublisher` is completed but later `onNext` is invoked. It violates the spec. `TestPublisher` should validate such misuse and the tests should create...
Currently all resources generation are handled in one class – `EnvoySnapshotFactory`. We could figure out a way to separate the logic into different classes and have a cleaner way to...
The property called **envoy-control.envoy.snapshot.localService.connectionIdleTimeout** should be renamed to **envoy-control.envoy.snapshot.ingress.commonHttp.connectionIdleTimeout** which would reflect what this setting actually does.
When a node connects with invalid configuration and causes exceptions we should log which service is issuing such XDS requests. We can simply extract it from `NodeMetadata`. Example: `pl.allegro.tech.servicemesh.envoycontrol.groups.NodeMetadataValidationException: INVALID_ARGUMENT:...
Currently, local DC gets `priority = 0` and all remote DCs get `priority = 1`. We should use Consul's latency measures to order the remote DCs so the fallback performance...
`RegisterIntoConsul` method should wait until the service instance is resolvable via local Consul agent. Currently the method exits as soon as the registration call is done and proceeds. When this...
## Motivation `Disposable` interface defines the `void dispose()` method, which is of eager nature and in most cases assumes non graceful, forceful release of underlying resources. There are cases where...
[reactor-core 3.5.3](https://github.com/reactor/reactor-core/releases/tag/v3.5.3) introduced a way to automatically propagate `ThreadLocal` values registered with the [context-propagation](https://github.com/micrometer-metrics/context-propagation) library. Combined with the use of [micrometer-tracing](https://github.com/micrometer-metrics/tracing) it can allow users to log anywhere in their...