Craig Gumbley

Results 123 comments of Craig Gumbley

Oh awesome! Thanks for the response!

SLES 15 should be supported as of v2.5.0. Let us know if there are any issues.

Ok interesting. I'll take a look on Tuesday with @pmcmaw . It should be an easy fix.

@me-minus This looks great. Would it be possible to add a spec test for this too?

@brendandburns Is this the right lib? https://github.com/AzureAD/azure-activedirectory-library-for-js

Enum sounds sensible to me... and actually removes a breaking element of the change.

Hey @fraenki ! I'm on PTO this week so pinging @pmcmaw and @david22swan for assistance!

There seems to be a lot of changes in this PR. Given that you (@alexjfisher @bastelfreak) have both been active here, what are you thoughts? What can @b4ldr do to...

@bastelfreak thanks. There is a bigger issue with the spec tests that we are going to look in to.. but I'll take a look at the validation failures tomorrow.