pdk icon indicating copy to clipboard operation
pdk copied to clipboard

Published 20 hours ago • verified publisher icon puppetlabs

Take "operatingsystem_support" parameter from answer.json

Open me-minus opened this issue 2 years ago • 2 comments

fixes for 'Take "operatingsystem_support" parameter from answer.json #1164 '

me-minus avatar Mar 25 '22 15:03 me-minus

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 30 '22 08:03 CLAassistant

@me-minus This looks great. Would it be possible to add a spec test for this too?

chelnak avatar Sep 30 '22 08:09 chelnak

@me-minus Looks like we have a few rubocop issues. Can you take a look?

chelnak avatar Jun 09 '23 14:06 chelnak

I think those last failures are unavoidable right now. I'll fix up the PR on Monday and get it merged.

Thank you!

chelnak avatar Jun 11 '23 10:06 chelnak

@me-minus Looking good! Thanks so much for spending the time on this (and waiting)!

chelnak avatar Jun 14 '23 08:06 chelnak

Have not been able to work on this until now (had a fix-papercuts-day at work) If you happen to go to devconf, find the crazy candy Swedes and tell them hello from me

me-minus avatar Jun 14 '23 08:06 me-minus

Trying to wrap my head around this one, what do I need to put into my answers.json to make this work?

moritzdietz avatar Dec 13 '23 09:12 moritzdietz