Chauncey comments

Results 174 comments of


Chauncey

When maxgroup is not set, ignore this field

To be honest, I don't know if this PR is correct. Perhaps you can add this PR in the agenda for the next Karmada meeting.

A deployment with a GPU request can still be deployed to a member cluster without a GPU Node

https://github.com/karmada-io/karmada/issues/3318 Perhaps we can filter out clusters without GPU nodes at the `preFilter` stage.

A deployment with a GPU request can still be deployed to a member cluster without a GPU Node

Hi, @tedli Can you attend the meeting tomorrow afternoon (December 19th, at 2:30 PM)? I hope to discuss the current issue with you.

adjust the Priority of General and Accurate Estimator of Karmada Scheduler

Just a question, will this modification require compatibility? Will it force users to upgrade the Estimator component?

feat: Refactor hpa_replicas_syncer_controller using a more stable solution

/cc @XiShanYongYe-Chang @lxtywypc Please take a look.

[umbrella] Auto detect whether workload needs to retain replicas in the member cluster through Retain operation

Hi @XiShanYongYe-Chang, has anyone picked up this issue yet? If not, i can pick up this one.

[umbrella] Auto detect whether workload needs to retain replicas in the member cluster through Retain operation

/unassign @chaunceyjiang /assign @chaosi-zju

[umbrella] sync replicas back to resource template if it is scaled in member cluster

Hi, @lxtywypc To be honest, I didn't understand what you meant. I think the core code of HPA controller should be this. https://github.com/kubernetes/kubernetes/blob/v1.27.3/pkg/controller/podautoscaler/horizontal.go#L876-L878

[umbrella] sync replicas back to resource template if it is scaled in member cluster

Yes, thank you for this work. This is exactly the result I wanted.

unable add annotation use plaintext overide whether annotation fileld is exist or not exist

I think it meets expectations. Please refer to [RFC 6902](https://datatracker.ietf.org/doc/html/rfc6902/)