Chauncey
Chauncey
``` go func mergeLabel(workload *unstructured.Unstructured, workNamespace string, binding metav1.Object, scope apiextensionsv1.ResourceScope) map[string]string { var workLabel = make(map[string]string) util.MergeLabel(workload, workv1alpha1.WorkNamespaceLabel, workNamespace) util.MergeLabel(workload, workv1alpha1.WorkNameLabel, names.GenerateWorkName(workload.GetKind(), workload.GetName(), workload.GetNamespace())) util.MergeLabel(workload, util.ManagedByKarmadaLabel, util.ManagedByKarmadaLabelValue) ... return...
/assign @chaunceyjiang
> I'm thinking if we need another overrider dedicated for container env, just like what we did for [ImageOverrider ](https://github.com/karmada-io/karmada/blob/7502b2507f3c4004d94e272f5e03e1dfde83d0e2/pkg/apis/policy/v1alpha1/override_types.go#L96). +1
> @chaunceyjiang Can you help add an agenda to the community meeting? Let's gather some feedback there ok. > Agreed. Maybe an EnvOverrider which can support add/replace/delete env as env...
> Thank for help. I've tried both two suggestions but still didn't work and got same response: ``` overriders: plaintext: - path: /spec/template/spec/containers/0/env/0 operator: add value: name: TEST value: captain-test...
> @chaunceyjiang Can you help open another issue to track the iteration tasks of env overrider? @mkloveyy want to be part of it. OK
``` yaml apiVersion: policy.karmada.io/v1alpha1 kind: PropagationPolicy metadata: name: nginx spec: resourceSelectors: - apiVersion: apps/v1 kind: Deployment name: nginx placement: clusterAffinity: labelSelector: matchExpressions: - key: stage operator: In values: - dev...
/cc @RainbowMango @Garrybest @jwcesign Please take a look.