feat: Refactor hpa_replicas_syncer_controller using a more stable solution

[chaunceyjiang]

What type of PR is this? /kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #4109

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: Refactor hpa_replicas_syncer_controller using a more stable solution.

[XiShanYongYe-Chang]

/assign

[XiShanYongYe-Chang]

Hi @chaunceyjiang the ut has failed.

[karmada-bot]

@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: lxtywypc.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Thanks a lot, @chaunceyjiang Can you help add some ut in the hpa_replicas_syncer_controller_test.go file.

Ask @lxtywypc to help take a review~ /cc @lxtywypc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[chaunceyjiang]

/cc @XiShanYongYe-Chang @lxtywypc Please take a look.

[codecov-commenter]

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (a948c63) 53.47% compared to head (9d30da3) 53.00%. Report is 21 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4132      +/-   ##
==========================================
- Coverage   53.47%   53.00%   -0.47%     
==========================================
  Files         234      239       +5     
  Lines       23279    23573     +294     
==========================================
+ Hits        12448    12495      +47     
- Misses      10150    10392     +242     
- Partials      681      686       +5     

Flag	Coverage Δ
unittests	53.00% <62.50%> (-0.47%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...pareplicassyncer/hpa_replicas_syncer_controller.go	45.04% <62.50%> (+0.45%)	:arrow_up:

... and 12 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[karmada-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from chaunceyjiang and additionally assign lonelycz after the PR has been reviewed. You can assign the PR to them by writing /assign @lonelycz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• cmd/OWNERS
• pkg/controllers/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[RainbowMango]

@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: lxtywypc.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

@lxtywypc I believe you are qualified as a Karmada member. Feel free to open an issue as per membership guidelines.

[lxtywypc]

@lxtywypc I believe you are qualified as a Karmada member. Feel free to open an issue as per membership guidelines.

Thanks for your invitation! I'm quite glad to. May I have you @RainbowMango and @XiShanYongYe-Chang as my sponsors?

[XiShanYongYe-Chang]

Thanks for your invitation! I'm quite glad to. May I have you @RainbowMango and @XiShanYongYe-Chang as my sponsors?

Hi @lxtywypc, sponsors must be from multiple member companies, you can refer to here: https://github.com/karmada-io/community/blob/main/community-membership.md#requirements

[lxtywypc]

Thanks for your invitation! I'm quite glad to. May I have you @RainbowMango and @XiShanYongYe-Chang as my sponsors?

Hi @lxtywypc, sponsors must be from multiple member companies, you can refer to here: https://github.com/karmada-io/community/blob/main/community-membership.md#requirements

Okay, Thanks for your remind. :)

[RainbowMango]

Do we still need it? cc @chaosi-zju to confirm

[chaosi-zju]

Do we still need it?

No, the overall scheme for hpa controlled replicas is replaced by #4707

[XiShanYongYe-Chang]

Let us close it. /lgtm

[RainbowMango]

/close

[karmada-bot]

@RainbowMango: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.