Sean-Logan Chase
Sean-Logan Chase
Ironically, my only nit would be to squash the two commits :) /approve /hold for nit
/hold cancel (The LGTM's already lost anyway)
/assign @brendandburns
I went through the files in the prow dir and renamed the easier ones. I managed to remove all of the instances of "whitelist", but "blacklist" has two configurations that...
> The [_pull-test-infra-bazel_](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/test-infra/23665/pull-test-infra-bazel/1439743221289717760#1:build-log.txt%3A6605) job says that there needs to be a dashboard made, I think? > > > * configuration error for (TestGroup) public-log-vendor-matcher: Each Test Group must be referenced...
If you want to use a dashboard that already exists, add the annotations and delete `config/testgrids/kubernetes/k8s-infra-public-pii/config.yaml`. It's trying to build the dashboard twice. If you're trying to build your own...
/lgtm Will wait for approval/merging until the dependent PR is in
/ok-to-test
Hello! It looks like Prow is trying to merge things, but there isn't an OWNERS file in this repository. As a result, the `approve` plugin can't determine who to assign...