rules_k8s
rules_k8s copied to clipboard
bazelbuild
Handle kubectl diff exit code when diffs are found
kubectl diff exits with code 1 if a diff is found. Because of the exit flag, this causes the bazel kubectl diff action to exit early. So this attempts to handle that without losing general script-level exit code handling.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
![google-cla[bot] avatar](https://avatars.githubusercontent.com/in/42202?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @goodspark. Thanks for your PR.
I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hm. I'm not sure I the test failure is exactly related to this change: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/bazelbuild_rules_k8s/636/pull-rules-k8s-e2e/1363912632892919808#1:build-log.txt%3A33
++ FAIL: 1=bazel-bin/examples/hellogrpc/go/server/staging.create
$ /usr/bin/kubectl --kubeconfig= --cluster=gke_rules-k8s_us-central1-f_testing --context=gke_rules-k8s_us-central1-f_testing --user= --namespace=build-1363912632892919808 create -f -
error: unable to recognize "STDIN": no matches for kind "Deployment" in version "apps/v1beta1"
Yeah given the error is no matches for kind "Deployment" in version "apps/v1beta1", this makes me think the k8s cluster that's being used for testing was upgraded without appropriate updates to the test files in this repo. apps/v1beta1 was removed in k8s 1.18. Perhaps the testing k8s cluster was upgraded to this or above?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chases2, goodspark
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [chases2]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
I've run into this and would be willing to take a stab at fixing the tests to get it merged, but it seems like the build history is gone. Any chance we could retrigger the tests and I can have a look?
@goodspark: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-rules-k8s-e2e | 7ef88ce352256fea00ec49a2d0729b9ff3e0286e | link | true | /test pull-rules-k8s-e2e |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
This seems to be failing tests, would you like to try and fix the tests or close out this PR?