Charlotte
Charlotte
Hm, I'm with @PeterNerlich on this. Not sure we should be adding editor-specific configs. Wouldn't most people have set this up globally in their editor already anyways (and if not,...
> I have an idea for a tradeoff. How about removing it from here and adding it to the devcontainer configuration, as it already contains some rough-related stuff? @PeterNerlich @charludo...
Thanks for the PR! I'd argue Option 4 would probably make the most sense, given that the install script makes sure prettier is available anyways?
> I am a bit out of my depth with those options. If you know how to implement an appropriate solution then we can close this PR with unmerged commits....
Sorry for taking so long to get back to you! I just realized I can't easily commit to your fork, so let's do it like this instead: This works great...
> @charludo do you think we could include this functionality into our [./tools/prettier.sh](https://github.com/digitalfabrik/integreat-cms/blob/204a66f9da45d906a7471baa8fb94ca580718563/tools/prettier.sh) instead of the `.git/hooks/pre-commit` which is not part of the version control itself? 🤔 Oops, yes, absolutely....
(Sorry, I mis-clicked when filtering for issues, it's not Q3 yet... 🤦🏼♀️ By the time I realized it was already done.)
> While testing this, I noticed that telephone numbers such as 0123 456789 or 0123-456789 aren't caught by this PR (yet). (I found in our test system that municipalities use...
@JoeyStk dash is now included. It would also be an option to only allow dashes after a certain amount of numbers (e.g. if we assume all phone numbers start with...
> Should we document this workflow somewhere? I actually think a devtool might be necessary (in a new PR) - to ensure that all wanted objects are exported, always with...