Charlotte

Results 115 comments of Charlotte

> I think this can be applied to events and locations as well. > > **UPD**. And the same problem occurs when saving to draft or submitting for approval. Right,...

> Opps, sorry, I actually found one issue: "Submit for approval" action has been broken for Observer [...] It can be reproduced, if Observer changes the page title. Sorry for...

> But the action itself works on develop - I can submit a title change for approval now. Ah, right. Then I guess it's not unrelated anymore, I'll look into...

> > Looks like this also happens on the develop branch, so it's unrelated to the changes > > I have re-checked: The error on the screen is reproduced on...

> > I mistakenly thought Observers could not change the title, but in fact it's just that they can't directly change the link > > Actually it seems they can...

> Thank you very much! Looks really good! I really would like to have a test for this, but since we don't have JS tests yet, I think we can...

Alright, I've lowered the required permissions. "Worst case" someone can generate a slug for a content objects they shouldn't - but since the function only returns the generated slug, not...

> > "Worst case" someone can generate a slug for a content objects they shouldn't > > This could be eliminated if we check for "cms.change_page_object" permission instead of "is...

> I've re-tested everything again and found no new problems except the one caused by removing the if-condition in the templates. As soon as the if-s are returned, I think...

@timoludwig I don´t think itś our stylesheet removing it makes no difference.