Charlotte

Results 115 comments of Charlotte

> Thanks for the answers @svenseeberg and @charludo. I don't want to block the pull request further. ☺️ No worries. Having to merge this fast is a not-too-great situation to...

> LGTM, thanks πŸš€ > > One thing I would change in the future is not showing internal comments as official responses. The red bordered message is also returned in...

@svenseeberg @timobrembeck @david-venhoff the three of you seemed most interested at the conference, would one of you mind doing the second review? πŸ˜…

> I also get an error ![image](https://private-user-images.githubusercontent.com/78504586/338555849-35e62208-ef49-4306-b5a8-0e6ce5653fc4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgxMDgzNjcsIm5iZiI6MTcxODEwODA2NywicGF0aCI6Ii83ODUwNDU4Ni8zMzg1NTU4NDktMzVlNjIyMDgtZWY0OS00MzA2LWI1YTgtMGU2Y2U1NjUzZmM0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjExVDEyMTQyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI3MmQ2NjA4MzJmOGJmNmMzMWRmMzAzZjU1MWYwN2E4NWMzZDI1ZTBjYmYwYjMzZjZjYjRjNTJkOTc0ZWM2MzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.X3OLWOlBIAZZKZ-NOkZCGjDO4Ept5CFJWmtH3_09K_k) > > The env seems to contain these values though πŸ€” ![image](https://private-user-images.githubusercontent.com/78504586/338556729-4fe208d6-4286-4393-9a0f-b8f873116646.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgxMDgzNjcsIm5iZiI6MTcxODEwODA2NywicGF0aCI6Ii83ODUwNDU4Ni8zMzg1NTY3MjktNGZlMjA4ZDYtNDI4Ni00MzkzLTlhMGYtYjhmODczMTE2NjQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjExVDEyMTQyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYzZTUxMGVjNGIxOGMzMDJmMzhjMzQyYTU2MDU3YjE4OGRlZjg0NmNiNzg4MjZmYzY0NDE3YTA0NzQ1MWZiNjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.m5TBx6HmOvbPYe2lsQhf7_zh9t5akdyupoh7FPFdNLs) Interesting. Not sure why that would happen, but I'll have a...

@david-venhoff [this SO post](https://stackoverflow.com/questions/50746147/postgresqls-initdb-fails-with-invalid-locale-settings-check-lang-and-lc-e) seemed relevant, describing the exact same issue with postgres. The first answer is some hacky workarounds.... ...and the second answer is "you didn't mention nix, but...

> I found [this](https://discourse.nixos.org/t/new-install-nix-wants-glibc-2-38-debian-12-has-2-36/36109/4) post which suggests to `unset LD_LIBRARY_PATH` and then the server finally starts on my laptop. I don't really know what this means though or where that...

> I didn't check out the other PR yet, but does it essentially tackle the same problems? If so, I'd suggest taking a vote in the team for the preferred...

Well said @deen13. One thing I'd like to add: I can see an maintainence-effort argument against keeping both solutions, but the maintainence required should be minimal, since in both cases...

> We would just also have to remove all the dev tools that depend on them. But since pre-commit can also run single checks, I don't see an important reason...

> Given how long it takes to get pull requests reviewed and merged, I hesitate to add more complexity here. Small moves. @PeterNerlich Yes, sorry, that was more of a...