이채준 - CJ Lee

Results 20 comments of 이채준 - CJ Lee

I think it will be better to append values to `data-state`. For the example like below, ```tsx ``` The `data-state` of `Toggle.Root` will be `data-state="open on"`. In this case, we...

I changed logic back to the concatenating raw css and kept track of filename with ending line number. I was able to create the correct warning message. However, when I...

@sapphi-red I think in this case, when `renderChunk` is being called, the `code` that is passed are already parsed and minimized, such as `.scss`, `.less`, `.styl`. In other words, `code`...

If I just print the css that is being passed to `minifyCss`, it looks like this. It is totally different from the original content. It looks like `chunkCSS = resolveAssetUrlsInCss(chunkCSS,...

Yes, you are right. I found out that I should've just went with 1-based number count and shouldn't have concat the css with `\n`. That was the cause of the...

Yeah.. Just concating is vague to map back.. I changed all the concating logic back to concating with `\n`.

Caught more mistakes and fixed them. ## AS-IS ![Screen Recording Jan 14](https://github.com/shadcn-ui/ui/assets/48273875/88f3e81c-882f-4a1e-ab11-63f3ab2fe25b) ## TO-BE ![Screen Recording Jan 14 (1)](https://github.com/shadcn-ui/ui/assets/48273875/94dff840-8d39-4fbd-8087-5c8c8e899e02)

I thought `md:grids-col-2` was a typo, in fact that was what needed to be removed. I have removed them and things work fine.

Hello, @shadcn ! Sorry to @ you, but can you please follow up?

> How build my icon in production image I saw the image above, and I can see that it might cause trouble. There are nested single-quotes within url property. Which...