ui icon indicating copy to clipboard operation
ui copied to clipboard

fix(themes): grid falling apart

Open chaejunlee opened this issue 1 year ago • 5 comments

When resizing the Themes, the grid falls apart.

It is due to the fact that 1fr of grid-cols-[260px_1fr] needs to be minmax(0,1fr).

And there was a typo in the className as well, which was grids-col-2.

I fixed both of the mistakes.

AS-IS

AS-IS

TO-BE

TO-BE

chaejunlee avatar Jan 14 '24 08:01 chaejunlee

@chaejunlee is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 14 '24 08:01 vercel[bot]

Caught more mistakes and fixed them.

AS-IS

Screen Recording Jan 14

TO-BE

Screen Recording Jan 14 (1)

chaejunlee avatar Jan 14 '24 08:01 chaejunlee

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2024 11:24am

vercel[bot] avatar Jan 14 '24 11:01 vercel[bot]

I thought md:grids-col-2 was a typo, in fact that was what needed to be removed.

I have removed them and things work fine.

Screenshot 2024-01-14 at 08 47 28

chaejunlee avatar Jan 14 '24 16:01 chaejunlee

Hello, @shadcn ! Sorry to @ you, but can you please follow up?

chaejunlee avatar Feb 05 '24 17:02 chaejunlee