Christian Edward Jackson-Gruber

Results 154 comments of Christian Edward Jackson-Gruber

I went to merge this, but it's breaking on OpenJDK8 on RBE with ``` Unrecognized option: --add-opens -- Error: Could not create the Java Virtual Machine. ```

Is the RBE-on-Java8 actually running bazel on java8?

We're starting to get further --incompatibles on recent bazel. If we don't update these rules to keep in step with the accelerated bazel release schedule, thigns are going to get...

Triaging this up, since while the original issues are obsolete, we need to bump the present state of the repo to be workable with recent bazels.

It's safe to say it's way way WAY behind, but it's something that we are looking at. It hasn't been abandoned as an idea, but hasn't been a priority as...

The main issue is that it has both kotlin-specific build concerns, and multiplatform-dependency concerns, and while I started adding some handling of gradle-metadata (which MP relies on) in my http://github.com/square/bazel_maven_repository...

This actually needs, more generally, to allow for annotation processor options to be passed in to kt_jvm_library/binary targets, either by passing javac_opts, or something like kapt_opts.

Ahhh. I see. You're seeing this as a global toolchain-level config to pass through, not a per-target. Ultimately both are needed, I think, based on my experience with Google and...

I don't think it will because of [this](https://github.com/bazelbuild/rules_kotlin/issues/396#issuecomment-729965196). To summarize, kotlinc compiler options are not kapt arguments, exactly, and there's a bunch of kapt-specific interop issues with java rules that...

Note for design - we need to be able to specify APT options, but also parse out -A options that were given in java_plugin() rules, which should be applied to...